Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 956623010: Move device-log UI strings to generated_resources (Closed)

Created:
5 years, 10 months ago by stevenjb
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move device-log UI strings to generated_resources BUG=462044 Committed: https://crrev.com/362ae2101b8a3710e1a07066746ed98bc577b52d Cr-Commit-Position: refs/heads/master@{#318173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
stevenjb
5 years, 10 months ago (2015-02-26 00:39:55 UTC) #2
stevenjb
Please go ahead and check the cq box if this looks good.
5 years, 10 months ago (2015-02-26 00:40:11 UTC) #3
Reilly Grant (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-26 00:44:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956623010/1
5 years, 10 months ago (2015-02-26 00:45:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/14867) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-26 00:47:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956623010/1
5 years, 10 months ago (2015-02-26 01:42:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 01:53:20 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 01:54:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/362ae2101b8a3710e1a07066746ed98bc577b52d
Cr-Commit-Position: refs/heads/master@{#318173}

Powered by Google App Engine
This is Rietveld 408576698