Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 956623004: freetype compiler fix (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

FreeType uses unsigned int, Skia uses int. Fix warning about assert which compared signed and unsigned. Committed: https://skia.googlesource.com/skia/+/4b583ac54b92ad6e7685bdfa2b68e7dd11ba0d28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ports/SkFontHost_FreeType_common.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
5 years, 10 months ago (2015-02-24 21:31:54 UTC) #2
bungeman-skia
lgtm
5 years, 10 months ago (2015-02-24 21:36:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956623004/1
5 years, 10 months ago (2015-02-24 21:37:15 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 21:43:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4b583ac54b92ad6e7685bdfa2b68e7dd11ba0d28

Powered by Google App Engine
This is Rietveld 408576698