Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 956623003: Use for-of loops in collection constructors (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use for-of loops in collection constructors This is to reduce code duplication but also to get the correct behavior when we make for-of handle abrupt completion correctly. BUG=None LOG=N R=adamk Committed: https://crrev.com/8ad35cb288498129a557bf7c80886126fa9a7904 Cr-Commit-Position: refs/heads/master@{#26834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -62 lines) Patch
M src/collection.js View 2 chunks +11 lines, -30 lines 0 comments Download
M src/weak-collection.js View 2 chunks +11 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-24 17:53:54 UTC) #1
adamk
No test changes? I thought the change you landed yesterday already changed for-of behavior.
5 years, 10 months ago (2015-02-24 18:44:49 UTC) #2
arv (Not doing code reviews)
On 2015/02/24 18:44:49, adamk wrote: > No test changes? I thought the change you landed ...
5 years, 10 months ago (2015-02-24 18:45:58 UTC) #3
adamk
lgtm
5 years, 10 months ago (2015-02-24 18:47:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956623003/1
5 years, 10 months ago (2015-02-24 18:52:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 19:12:40 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 19:12:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ad35cb288498129a557bf7c80886126fa9a7904
Cr-Commit-Position: refs/heads/master@{#26834}

Powered by Google App Engine
This is Rietveld 408576698