Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 956603004: Revert of Remove LSan options/suppressions from test_env.py. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove LSan options/suppressions from test_env.py. (patchset #1 id:1 of https://codereview.chromium.org/940033002/) Reason for revert: Breaks Linux ASAN: https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/19163/steps/isolate%20tests/logs/stdio The error is: MappingError: Input file /mnt/data/b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/lsan/suppressions.txt doesn't exist Original issue's description: > Remove LSan options/suppressions from test_env.py. > > Those are now compiled into the executable. > Also remove tools/lsan/ which used to house the suppressions file. > > BUG=302040 > R=kjellander@chromium.org > > Committed: https://crrev.com/09fef383665c6d75776bb0b649b29685b38ce617 > Cr-Commit-Position: refs/heads/master@{#318035} TBR=kjellander@chromium.org,earthdok@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=302040 Committed: https://crrev.com/207c1a328efe47f10bb0fb41411936051b2bf062 Cr-Commit-Position: refs/heads/master@{#318043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M testing/test_env.py View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/lsan/PRESUBMIT.py View 1 chunk +33 lines, -0 lines 0 comments Download
A tools/lsan/suppressions.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of Remove LSan options/suppressions from test_env.py.
5 years, 10 months ago (2015-02-25 14:29:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956603004/1
5 years, 10 months ago (2015-02-25 14:29:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 14:30:36 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 14:31:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/207c1a328efe47f10bb0fb41411936051b2bf062
Cr-Commit-Position: refs/heads/master@{#318043}

Powered by Google App Engine
This is Rietveld 408576698