Publish location files for Mojo binaries uploaded from Chromium.

mojo/services/upload_service.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import imp
 import os
 import subprocess
 import sys
@@ skipping 56 matching lines @@
     gsutil_cp(mojom_zip_file.name, dest, dry_run)
 
 
 def upload_binary(service, binary_dir, platform, dry_run):
   dest_dir = "gs://mojo/" + service + "/" + version + "/" + platform + "/"
   should_zip = service in SERVICES_WITH_ZIPPED_BINARIES
   binary_name = service + ".mojo"
   absolute_binary_path = os.path.join(root_path, binary_dir, binary_name)
 
   if not should_zip:
+    # Upload the binary.
     dest = dest_dir + binary_name
     gsutil_cp(absolute_binary_path, dest, dry_run)
+
+    # Update the pointer to the service's location to point to the
+    # newly-uploaded binary.
+    service_location = dest.replace("gs://", "https://storage.googleapis.com/")
+    location_file = ("gs://mojo/services/" + platform + "/" + service +
+                     "_location")

[jamesr, 2015/02/24 22:07:19]

what information are we uploading here that isn't already in the URL?

[blundell, 2015/02/25 13:07:31]

gs://mojo/services/<platform>/<service>_location is a file that stores the URL
at which the binary for <service> can be found. The purpose of this file is to
allow a server app to serve the current versions of Mojo apps (e.g., apps
published from the Mojo and Chromium repos) without having to be aware of the
details of which apps are published from where, under which conventions for path
constructions, etc: When the server app receives a request for <service>, it can
read the current location of the <service> binary from
https://storage.googleapis.com/mojo/services/<platform>/<service>_location and
then return a redirect to that location.

If you're asking "what information is in the contents of
gs://mojo/services/<platform>/<service>_location that isn't embedded in that
URL", the answer is the version. The reason I chose to store the URL of the
binary rather than e.g. just the version in this pointer file is to allow
flexibility in exactly where/with what path construction conventions binaries
are uploaded without requiring changes to the server app.

+    with tempfile.NamedTemporaryFile() as tmp:
+      tmp.write(service_location)
+      tmp.flush()
+      gsutil_cp(tmp.name, location_file, dry_run)
     return
 
   # Zip the binary before uploading it to the cloud.
   dest = dest_dir + binary_name + ".zip"
   with tempfile.NamedTemporaryFile() as binary_zip_file:
     with zipfile.ZipFile(binary_zip_file, 'w') as z:
       with open(absolute_binary_path) as service_binary:
         zipinfo = zipfile.ZipInfo(binary_name)
         zipinfo.external_attr = 0o777 << 16
         zipinfo.compress_type = zipfile.ZIP_DEFLATED
@@ skipping 39 matching lines @@
                   "android-arm", args.dry_run)
 
   if not args.dry_run:
     print "Uploaded artifacts for version %s" % (version, )
   else:
     print "No artifacts uploaded (dry run)"
   return 0
 
 if __name__ == '__main__':
   sys.exit(main())