Issue 956573002: Move network service to using //build/module_args/mojo.gni

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 956573002: Move network service to using //build/module_args/mojo.gni (Closed)

Created:
5 years, 10 months ago by blundell

Modified:
5 years, 10 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move network service to using //build/module_args/mojo.gni //build/module_args/mojo.gni is the canonical place for setting information that might differ between repos, such as the location of the Mojo SDK. Committed: https://crrev.com/e87adc2cb1504757f3f1fc093fc1dbb8dff303d9 Cr-Commit-Position: refs/heads/master@{#318015}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	mojo/services/network/public/cpp/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	mojo/services/network/public/interfaces/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956573002/1

5 years, 10 months ago (2015-02-25 09:49:28 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 09:53:25 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e87adc2cb1504757f3f1fc093fc1dbb8dff303d9
Cr-Commit-Position: refs/heads/master@{#318015}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages