Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: Source/core/layout/style/SVGLayoutStyleDefs.cpp

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: A few more TEs. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/style/SVGLayoutStyleDefs.cpp
diff --git a/Source/core/layout/style/SVGLayoutStyleDefs.cpp b/Source/core/layout/style/SVGLayoutStyleDefs.cpp
index 8a0bfc441b94bdacef65b62b3fdfd6cc364d2771..f680c446dd0ec694ab22ebb58fd0d14f290717a6 100644
--- a/Source/core/layout/style/SVGLayoutStyleDefs.cpp
+++ b/Source/core/layout/style/SVGLayoutStyleDefs.cpp
@@ -144,7 +144,7 @@ StyleMiscData::StyleMiscData(const StyleMiscData& other)
, floodColor(other.floodColor)
, floodOpacity(other.floodOpacity)
, lightingColor(other.lightingColor)
- , baselineShiftValue(other.baselineShiftValue->clone())
+ , baselineShiftValue(other.baselineShiftValue)
{
}
@@ -153,7 +153,7 @@ bool StyleMiscData::operator==(const StyleMiscData& other) const
return floodOpacity == other.floodOpacity
&& floodColor == other.floodColor
&& lightingColor == other.lightingColor
- && *baselineShiftValue == *other.baselineShiftValue;
+ && baselineShiftValue == other.baselineShiftValue;
}
StyleResourceData::StyleResourceData()

Powered by Google App Engine
This is Rietveld 408576698