Source/core/layout/style/SVGLayoutStyle.cpp - Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/style/SVGLayoutStyle.cpp

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: A few more TEs. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/style/SVGLayoutStyle.cpp

diff --git a/Source/core/layout/style/SVGLayoutStyle.cpp b/Source/core/layout/style/SVGLayoutStyle.cpp

index bd7768ab3a363f15bffc619c519766cf4aaf4e88..5dbe3d98a811f2add404cb404d737c4ab7ad1266 100644

--- a/Source/core/layout/style/SVGLayoutStyle.cpp

+++ b/Source/core/layout/style/SVGLayoutStyle.cpp

@@ -155,7 +155,7 @@ bool SVGLayoutStyle::diffNeedsLayoutAndPaintInvalidation(const SVGLayoutStyle* o

return true;

// Text related properties influence layout.

- if (*misc->baselineShiftValue != *other->misc->baselineShiftValue)

+ if (misc->baselineShiftValue != other->misc->baselineShiftValue)

return true;

// These properties affect the cached stroke bounding box rects.