Source/core/animation/css/CSSPropertyEquality.cpp - Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/css/CSSPropertyEquality.cpp

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: A few more TEs. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/css/CSSPropertyEquality.cpp

diff --git a/Source/core/animation/css/CSSPropertyEquality.cpp b/Source/core/animation/css/CSSPropertyEquality.cpp

index e0a2ce38c7d315845c0a8cc3be6cb1fcfce6b821..7bb8cf0e8681e76f1736ba66d494e0071d99ba1a 100644

--- a/Source/core/animation/css/CSSPropertyEquality.cpp

+++ b/Source/core/animation/css/CSSPropertyEquality.cpp

@@ -71,7 +71,7 @@ bool CSSPropertyEquality::propertiesEqual(CSSPropertyID prop, const LayoutStyle&

case CSSPropertyBackgroundSize:

return fillLayersEqual<CSSPropertyBackgroundSize>(a.backgroundLayers(), b.backgroundLayers());

case CSSPropertyBaselineShift:

- return dataEquivalent(a.baselineShiftValue(), b.baselineShiftValue());

+ return a.baselineShiftValue() == b.baselineShiftValue();

case CSSPropertyBorderBottomColor:

return a.borderBottomColor() == b.borderBottomColor()

&& a.visitedLinkBorderBottomColor() == b.visitedLinkBorderBottomColor();