Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: Source/core/animation/StringKeyframe.cpp

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: A few more TEs. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/StringKeyframe.cpp
diff --git a/Source/core/animation/StringKeyframe.cpp b/Source/core/animation/StringKeyframe.cpp
index dc9438e01db591f8debfffa48e622ca271e46c26..e146041d508aef07a822538c1c72e0444f5825ba 100644
--- a/Source/core/animation/StringKeyframe.cpp
+++ b/Source/core/animation/StringKeyframe.cpp
@@ -177,6 +177,7 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
case CSSPropertyWidth:
range = RangeNonNegative;
// Fall through
+ case CSSPropertyBaselineShift:
case CSSPropertyBottom:
case CSSPropertyLeft:
case CSSPropertyLetterSpacing:
@@ -200,6 +201,10 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
if (property == CSSPropertyFontSize)
fallBackToLegacy = true;
+ // FIXME: Handle keywords e.g. 'baseline', 'sub'.
+ if (property == CSSPropertyBaselineShift)
+ fallBackToLegacy = true;
+
// FIXME: Handle keywords e.g. 'normal'
if (property == CSSPropertyLetterSpacing)
fallBackToLegacy = true;
@@ -329,7 +334,6 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
case CSSPropertyStrokeWidth:
range = RangeNonNegative;
// Fall through
- case CSSPropertyBaselineShift:
case CSSPropertyStrokeDashoffset: {
RefPtrWillBeRawPtr<Interpolation> interpolation = SVGLengthStyleInterpolation::maybeCreate(*fromCSSValue, *toCSSValue, property, range);
if (interpolation)

Powered by Google App Engine
This is Rietveld 408576698