Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Drop SVGLengthContext changes for now. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/Source/core/css/resolver/StyleBuilderCustom.cpp b/Source/core/css/resolver/StyleBuilderCustom.cpp

index 4239ef7b8f88b797e81b034ee09258ff8fdff51b..7b8789ae15ae0abc9c40bd3291328255aa901331 100644

--- a/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -942,7 +942,7 @@ void StyleBuilderFunctions::applyValueCSSPropertyBaselineShift(StyleResolverStat

CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

if (!primitiveValue->isValueID()) {

svgStyle.setBaselineShift(BS_LENGTH);

- svgStyle.setBaselineShiftValue(SVGLength::fromCSSPrimitiveValue(primitiveValue));

+ svgStyle.setBaselineShiftValue(StyleBuilderConverter::convertLength(state, primitiveValue));

return;

}

switch (primitiveValue->getValueID()) {