Source/core/css/LayoutStyleCSSValueMapping.cpp - Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/LayoutStyleCSSValueMapping.cpp

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Drop SVGLengthContext changes for now. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/LayoutStyleCSSValueMapping.cpp

diff --git a/Source/core/css/LayoutStyleCSSValueMapping.cpp b/Source/core/css/LayoutStyleCSSValueMapping.cpp

index cc4be95739c82878c4c54248f031b6447b755cfa..b524f9e474080b7a3dab7a7980c6674aa963a7b2 100644

--- a/Source/core/css/LayoutStyleCSSValueMapping.cpp

+++ b/Source/core/css/LayoutStyleCSSValueMapping.cpp

@@ -2532,7 +2532,7 @@ PassRefPtrWillBeRawPtr<CSSValue> LayoutStyleCSSValueMapping::get(CSSPropertyID p

case BS_SUB:

return CSSPrimitiveValue::createIdentifier(CSSValueSub);

case BS_LENGTH:

- return SVGLength::toCSSPrimitiveValue(svgStyle.baselineShiftValue());

+ return zoomAdjustedPixelValueForLength(svgStyle.baselineShiftValue(), style);

}

ASSERT_NOT_REACHED();

return nullptr;