Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Drop SVGLengthContext changes for now. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details. 12 * Library General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU Library General Public License 14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to 15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA. 17 * Boston, MA 02110-1301, USA.
18 */ 18 */
19 19
20 #include "config.h" 20 #include "config.h"
21 21
22 #include "core/layout/svg/SVGTextLayoutEngineBaseline.h" 22 #include "core/layout/svg/SVGTextLayoutEngineBaseline.h"
23 23
24 #include "core/layout/LayoutObject.h" 24 #include "core/layout/LayoutObject.h"
25 #include "core/layout/style/SVGLayoutStyle.h" 25 #include "core/layout/style/SVGLayoutStyle.h"
26 #include "core/layout/svg/SVGTextMetrics.h" 26 #include "core/layout/svg/SVGTextMetrics.h"
27 #include "core/svg/SVGLengthContext.h" 27 #include "platform/LengthFunctions.h"
28 #include "platform/fonts/Font.h" 28 #include "platform/fonts/Font.h"
29 #include "platform/text/UnicodeRange.h" 29 #include "platform/text/UnicodeRange.h"
30 30
31 namespace blink { 31 namespace blink {
32 32
33 SVGTextLayoutEngineBaseline::SVGTextLayoutEngineBaseline(const Font& font) 33 SVGTextLayoutEngineBaseline::SVGTextLayoutEngineBaseline(const Font& font)
34 : m_font(font) 34 : m_font(font)
35 { 35 {
36 } 36 }
37 37
38 float SVGTextLayoutEngineBaseline::calculateBaselineShift(const SVGLayoutStyle& style, SVGElement* contextElement) const 38 float SVGTextLayoutEngineBaseline::calculateBaselineShift(const LayoutStyle& sty le) const
39 { 39 {
40 if (style.baselineShift() == BS_LENGTH) { 40 const SVGLayoutStyle& svgStyle = style.svgStyle();
41 RefPtrWillBeRawPtr<SVGLength> baselineShiftValueLength = style.baselineS hiftValue(); 41 if (svgStyle.baselineShift() == BS_LENGTH) {
42 if (baselineShiftValueLength->unitType() == LengthTypePercentage) 42 const float zoom = style.effectiveZoom();
43 return baselineShiftValueLength->scaleByPercentage(m_font.fontDescri ption().computedPixelSize()); 43 return floatValueForLength(svgStyle.baselineShiftValue(), m_font.fontDes cription().computedPixelSize() * zoom) / zoom;
44
45 SVGLengthContext lengthContext(contextElement);
46 return baselineShiftValueLength->value(lengthContext);
47 } 44 }
48 45
49 switch (style.baselineShift()) { 46 switch (svgStyle.baselineShift()) {
50 case BS_BASELINE: 47 case BS_BASELINE:
51 return 0; 48 return 0;
52 case BS_SUB: 49 case BS_SUB:
53 return -m_font.fontMetrics().floatHeight() / 2; 50 return -m_font.fontMetrics().floatHeight() / 2;
54 case BS_SUPER: 51 case BS_SUPER:
55 return m_font.fontMetrics().floatHeight() / 2; 52 return m_font.fontMetrics().floatHeight() / 2;
56 default: 53 default:
57 ASSERT_NOT_REACHED(); 54 ASSERT_NOT_REACHED();
58 return 0; 55 return 0;
59 } 56 }
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 } 220 }
224 221
225 // Horizontal advance calculation. 222 // Horizontal advance calculation.
226 if (angle && !orientationIsMultiplyOf180Degrees) 223 if (angle && !orientationIsMultiplyOf180Degrees)
227 return metrics.height(); 224 return metrics.height();
228 225
229 return metrics.width(); 226 return metrics.width();
230 } 227 }
231 228
232 } 229 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698