Issue 956443003: Update project to match OSS template

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 956443003: Update project to match OSS template (Closed)

Created:
5 years, 10 months ago by Søren Gjesse

Modified:
5 years, 10 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/collection.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update project to match OSS template R=ricow@google.com BUG= Committed: https://github.com/dart-lang/collection/commit/683b9f57c9ede261bc394d6280a93ef1a51e140e

Patch Set 2 : Added .gitignore and empty .status #

Patch Set 4 : Addressed review comments #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -3 lines)			Patch
A	.gitignore	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	AUTHORS	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	CONTRIBUTING.md	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	LICENSE	View		1 chunk	+1 line, -1 line	0 comments	Download
M	README.md	View	1 2 3	2 chunks	+7 lines, -1 line	0 comments	Download
A	codereview.settings	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	pubspec.yaml	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

lgtm https://codereview.chromium.org/956443003/diff/40001/README.md File README.md (right): https://codereview.chromium.org/956443003/diff/40001/README.md#newcode75 README.md:75: [tracker]: https://github.com/dart-lang/sample/issues url

5 years, 10 months ago (2015-02-24 11:42:17 UTC) #2

Søren Gjesse

https://codereview.chromium.org/956443003/diff/40001/README.md File README.md (right): https://codereview.chromium.org/956443003/diff/40001/README.md#newcode75 README.md:75: [tracker]: https://github.com/dart-lang/sample/issues On 2015/02/24 11:42:17, ricow1 wrote: > url ...

5 years, 10 months ago (2015-02-24 12:11:30 UTC) #3

Søren Gjesse

5 years, 10 months ago (2015-02-24 12:11:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
683b9f57c9ede261bc394d6280a93ef1a51e140e (presubmit successful).