Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 956433002: Introduce MockHttpCache::backend() and move a few callers to it. (Closed)

Created:
5 years, 10 months ago by pcc1
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, rvargas (doing something else)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce MockHttpCache::backend() and move a few callers to it. The MockHttpCache::OpenBackendEntry and CreateBackendEntry functions may have been making invalid virtual calls if the disk cache backend was not a MockDiskCache. Fixes HttpCache.RangeGET_LargeValues under -fsanitize=cfi-vptr. BUG=457523 TEST=net_unittests R=rdsmith@chromium.org Committed: https://crrev.com/642379648bdca92a835fb587dd987310161d26f7 Cr-Commit-Position: refs/heads/master@{#317970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M net/http/mock_http_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/mock_http_cache.cc View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
pcc1
5 years, 10 months ago (2015-02-24 04:01:10 UTC) #1
Randy Smith (Not in Mondays)
Sorry, while this is a simple change, I don't have an understanding of the requirements ...
5 years, 10 months ago (2015-02-24 18:02:32 UTC) #3
rvargas (doing something else)
lgtm
5 years, 10 months ago (2015-02-24 23:03:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956433002/1
5 years, 10 months ago (2015-02-24 23:05:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/14239) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-24 23:23:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956433002/1
5 years, 10 months ago (2015-02-24 23:25:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/14291) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-24 23:42:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956433002/1
5 years, 10 months ago (2015-02-25 03:29:48 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 03:33:03 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 03:33:29 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/642379648bdca92a835fb587dd987310161d26f7
Cr-Commit-Position: refs/heads/master@{#317970}

Powered by Google App Engine
This is Rietveld 408576698