base/trace_event/memory_dump_manager.h - Issue 956413002: [tracing] Enable actual generation of memory dump points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_manager.h

Issue 956413002: [tracing] Enable actual generation of memory dump points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_sandbox_fix

Patch Set: Address review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/memory_dump_manager.h

diff --git a/base/trace_event/memory_dump_manager.h b/base/trace_event/memory_dump_manager.h

index 1a22e61b34a5640ee5291458b29da6b14e4ceaef..8a9b3b7e95a414dc72d3b17333199ff97d0bf21f 100644

--- a/base/trace_event/memory_dump_manager.h

+++ b/base/trace_event/memory_dump_manager.h

@@ -43,7 +43,7 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {

// Requests a memory dump. The dump might happen or not depending on the

// filters and categories specified when enabling tracing.

- void RequestDumpPoint(DumpPointType type);

+ void RequestDumpPoint(DumpPointType dump_point_type);

// TraceLog::EnabledStateObserver implementation.

void OnTraceLogEnabled() override;

@@ -65,7 +65,7 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {

void BroadcastDumpRequest();

// Creates a dump point for the current process and appends it to the trace.

- void CreateLocalDumpPoint();

+ void CreateLocalDumpPoint(DumpPointType dump_point_type, uint64 guid);

std::vector<MemoryDumpProvider*> dump_providers_registered_; // Not owned.

std::vector<MemoryDumpProvider*> dump_providers_enabled_; // Not owned.

« no previous file with comments | « no previous file | base/trace_event/memory_dump_manager.cc » ('j') | no next file with comments »