base/trace_event/trace_event.h - Issue 956413002: [tracing] Enable actual generation of memory dump points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event.h

Issue 956413002: [tracing] Enable actual generation of memory dump points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_sandbox_fix

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_event.h

diff --git a/base/trace_event/trace_event.h b/base/trace_event/trace_event.h

index e12d8f423f526181d3886af1e92d49e7e9dcd39b..c30a84a973edb6c7ca1217abff84a93b3a51b67b 100644

--- a/base/trace_event/trace_event.h

+++ b/base/trace_event/trace_event.h

@@ -1039,6 +1039,7 @@ TRACE_EVENT_API_CLASS_EXPORT extern \

#define TRACE_EVENT_PHASE_CREATE_OBJECT ('N')

#define TRACE_EVENT_PHASE_SNAPSHOT_OBJECT ('O')

#define TRACE_EVENT_PHASE_DELETE_OBJECT ('D')

+#define TRACE_EVENT_PHASE_MEMORY_DUMP ('v')

dsinclair 2015/02/26 17:54:54 Can you make sure this gets added back into the tr

picksi 2015/02/26 17:58:04 Is there any rationale for choosing lowercase or u

dsinclair 2015/02/26 18:02:06 We don't have a proscribed system for dolling thes

Primiano Tucci (use gerrit) 2015/02/26 18:59:43 I used 'v' because I saw that in the Trace Event f

Primiano Tucci (use gerrit) 2015/02/26 18:59:43 It's already there, I took it from https://docs.g

// Flags for changing the behavior of TRACE_EVENT_API_ADD_TRACE_EVENT.

#define TRACE_EVENT_FLAG_NONE (static_cast<unsigned char>(0))

« base/trace_event/memory_dump_manager.cc ('K') | « base/trace_event/memory_dump_manager.cc ('k') | no next file » | no next file with comments »