chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js - Issue 956403003: Fix the issue that wallpaper changes twice when both "onChanged" and "onAlarm" are fired.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

Issue 956403003: Fix the issue that wallpaper changes twice when both "onChanged" and "onAlarm" are fired. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the code review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/wallpaper_manager/js/util.js ('K') | « chrome/browser/resources/chromeos/wallpaper_manager/js/util.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

diff --git a/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js b/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

index fbdb27f6aca89fa8c2a6568ed8b3c54c0e1b688c..f9e313e65a49d08aa5ae66d8c098d54558567c5c 100644

--- a/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

+++ b/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

@@ -596,8 +596,9 @@ function WallpaperManager(dialogDom) {

self.showError_(str('downloadFailed'));

self.wallpaperRequest_ = null;

};

- WallpaperUtil.fetchURL(wallpaperURL, 'arraybuffer', onSuccess,

- onFailure, self.wallpaperRequest_);

+ WallpaperUtil.fetchURL(wallpaperURL, 'arraybuffer',

+ onSuccess, onFailure, function() {},

+ self.wallpaperRequest_);

});

break;

default:

« chrome/browser/resources/chromeos/wallpaper_manager/js/util.js ('K') | « chrome/browser/resources/chromeos/wallpaper_manager/js/util.js ('k') | no next file » | no next file with comments »