Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 956373002: Default-enable external startup data for Linux for stand-alone builds. (Closed)

Created:
5 years, 10 months ago by vogelheim
Modified:
5 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Default-enable external startup data for Linux for stand-alone builds. Notes: - Other platforms to follow later. - This follows Chromium practice, that mostly uses this feature these days. - The statically linked-in startup data will stay. So whoever prefers the old way just needs to set the flag differently. Reland crrev.com/959693002, once crrev.com/960883003 is in. R=machenbach@chromium.org BUG= Committed: https://crrev.com/a0bdb103b676b4c7fa6b9f2e7149e716549c05d1 Cr-Commit-Position: refs/heads/master@{#26980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/standalone.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vogelheim
5 years, 10 months ago (2015-02-26 16:09:11 UTC) #1
Michael Achenbach
lgtm
5 years, 10 months ago (2015-02-26 17:08:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956373002/1
5 years, 9 months ago (2015-03-04 12:20:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 12:21:57 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a0bdb103b676b4c7fa6b9f2e7149e716549c05d1 Cr-Commit-Position: refs/heads/master@{#26980}
5 years, 9 months ago (2015-03-04 12:22:08 UTC) #8
vogelheim
5 years, 9 months ago (2015-03-04 13:52:07 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/981463005/ by vogelheim@chromium.org.

The reason for reverting is: The CL caused two issues:
- a weird build issue on V8 mips builder
- d8 cannot be invoked via PATH, since then it doesn't find its external
snapshot.

The 2nd issue might even be WAI, but this needs more consideration..

Powered by Google App Engine
This is Rietveld 408576698