Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: components/signin/core/browser/signin_manager_base.cc

Issue 956363002: Add account id/gaia id to sign-in internals page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/signin/core/browser/signin_manager_base.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/signin_manager_base.cc
diff --git a/components/signin/core/browser/signin_manager_base.cc b/components/signin/core/browser/signin_manager_base.cc
index 02cf48069ba1dc3a1ca1d8ef0eeeb87e6532df7e..08cdc6ba44d7c28e491fa71a53738c4e8b0c1718 100644
--- a/components/signin/core/browser/signin_manager_base.cc
+++ b/components/signin/core/browser/signin_manager_base.cc
@@ -94,7 +94,6 @@ void SigninManagerBase::SetAuthenticatedUsername(const std::string& username) {
username,
username);
client_->GetPrefs()->SetString(prefs::kGoogleServicesUsername, username);
- NotifyDiagnosticsObservers(USERNAME, username);
// Go ahead and update the last signed in username here as well. Once a
// user is signed in the two preferences should match. Doing it here as
@@ -137,14 +136,6 @@ void SigninManagerBase::RemoveSigninDiagnosticsObserver(
}
void SigninManagerBase::NotifyDiagnosticsObservers(
- const UntimedSigninStatusField& field,
- const std::string& value) {
- FOR_EACH_OBSERVER(SigninDiagnosticsObserver,
- signin_diagnostics_observers_,
- NotifySigninValueChanged(field, value));
-}
-
-void SigninManagerBase::NotifyDiagnosticsObservers(
const TimedSigninStatusField& field,
const std::string& value) {
FOR_EACH_OBSERVER(SigninDiagnosticsObserver,
« no previous file with comments | « components/signin/core/browser/signin_manager_base.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698