Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/signin/core/browser/signin_internals_util.h

Issue 956363002: Add account id/gaia id to sign-in internals page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_internals_util.h
diff --git a/components/signin/core/browser/signin_internals_util.h b/components/signin/core/browser/signin_internals_util.h
index d5856eb2a3d2d43eaa43209326c2550527170024..4ffe7f6a2ff4f9a25d57bd6f033b2dfc9d4b08c2 100644
--- a/components/signin/core/browser/signin_internals_util.h
+++ b/components/signin/core/browser/signin_internals_util.h
@@ -27,7 +27,9 @@ enum {
};
enum UntimedSigninStatusField {
- USERNAME = UNTIMED_FIELDS_BEGIN,
+ ACCOUNT_ID = UNTIMED_FIELDS_BEGIN,
+ GAIA_ID,
+ USERNAME,
UNTIMED_FIELDS_END
};
@@ -37,12 +39,10 @@ enum {
};
enum TimedSigninStatusField {
- SIGNIN_TYPE = TIMED_FIELDS_BEGIN,
- AUTHENTICATION_RESULT_RECEIVED,
+ AUTHENTICATION_RESULT_RECEIVED = TIMED_FIELDS_BEGIN,
REFRESH_TOKEN_RECEIVED,
- GET_USER_INFO_STATUS,
- UBER_TOKEN_STATUS,
- MERGE_SESSION_STATUS,
+ SIGNIN_STARTED,
+ SIGNIN_COMPLETED,
TIMED_FIELDS_END
};
@@ -65,8 +65,6 @@ std::string SigninStatusFieldToString(TimedSigninStatusField field);
class SigninDiagnosticsObserver {
public:
// Credentials and signin related changes.
- virtual void NotifySigninValueChanged(const UntimedSigninStatusField& field,
- const std::string& value) {}
virtual void NotifySigninValueChanged(const TimedSigninStatusField& field,
const std::string& value) {}
// OAuth tokens related changes.
« no previous file with comments | « components/signin/core/browser/about_signin_internals.cc ('k') | components/signin/core/browser/signin_internals_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698