Add account id/gaia id to sign-in internals page.

Add account id/gaia id to sign-in internals page.

BUG=405038
Committed: https://crrev.com/373bf95a0e730548db69a625cf147295b3d8fcd9
Cr-Commit-Position: refs/heads/master@{#320907}

[Roger Tawa OOO till Jul 10th, 2015-02-26 18:46:24]

Patchset #1 (id:1) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-02-26 18:46:30]

Patchset #1 (id:20001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-02-26 18:48:20]

rogerta@chromium.org changed reviewers:
+ mlerman@chromium.org

[Roger Tawa OOO till Jul 10th, 2015-02-26 18:48:21]

Hi Mike,

Please take a look.  I added the account id and gaia id to the page.  I also
took the time to cleanup the strings and exactly where/when they get logged. 
Finally, also fixed the cros problem :-)

Thanks.

[Mike Lerman, 2015-03-02 15:58:56]

On 2015/02/26 18:48:21, Roger Tawa wrote:
> Hi Mike,
> 
> Please take a look.  I added the account id and gaia id to the page.  I also
> took the time to cleanup the strings and exactly where/when they get logged. 
> Finally, also fixed the cros problem :-)
> 
> Thanks.

It's odd that AboutSigninInternals and SigninManagerBase have two communication
channels: The AboutSigninInternals has a SigninManagerBase and calls methods on
it, and observes the SigninManagerBase. AboutSigninInternals is also a
DiagnosticsObserver. Ideally, we should just have one type of observation
between these day classes.

[Roger Tawa OOO till Jul 10th, 2015-03-14 23:48:25]

On 2015/03/02 15:58:56, Mike Lerman wrote:
> On 2015/02/26 18:48:21, Roger Tawa wrote:
> > Hi Mike,
> > 
> > Please take a look.  I added the account id and gaia id to the page.  I also
> > took the time to cleanup the strings and exactly where/when they get logged.

> > Finally, also fixed the cros problem :-)
> > 
> > Thanks.
> 
> It's odd that AboutSigninInternals and SigninManagerBase have two
communication
> channels: The AboutSigninInternals has a SigninManagerBase and calls methods
on
> it, and observes the SigninManagerBase. AboutSigninInternals is also a
> DiagnosticsObserver. Ideally, we should just have one type of observation
> between these day classes.

Not odd.  One communication channel is for public information from the SM.  The
other is for purely diagnostic information internal to SM, that we want to
display on the about signin page.  I don't think we should expose internal
information in the public communication channel, and it does not seem best to
duplicate public information in the diagnostic comm just so that ASI only needs
to register with one channel.

[Mike Lerman, 2015-03-17 00:49:19]

On 2015/03/14 23:48:25, Roger Tawa wrote:
> On 2015/03/02 15:58:56, Mike Lerman wrote:
> > On 2015/02/26 18:48:21, Roger Tawa wrote:
> > > Hi Mike,
> > > 
> > > Please take a look.  I added the account id and gaia id to the page.  I
also
> > > took the time to cleanup the strings and exactly where/when they get
logged.
> 
> > > Finally, also fixed the cros problem :-)
> > > 
> > > Thanks.
> > 
> > It's odd that AboutSigninInternals and SigninManagerBase have two
> communication
> > channels: The AboutSigninInternals has a SigninManagerBase and calls methods
> on
> > it, and observes the SigninManagerBase. AboutSigninInternals is also a
> > DiagnosticsObserver. Ideally, we should just have one type of observation
> > between these day classes.
> 
> Not odd.  One communication channel is for public information from the SM. 
The
> other is for purely diagnostic information internal to SM, that we want to
> display on the about signin page.  I don't think we should expose internal
> information in the public communication channel, and it does not seem best to
> duplicate public information in the diagnostic comm just so that ASI only
needs
> to register with one channel.

That's fair. LGTM.

[Roger Tawa OOO till Jul 10th, 2015-03-17 12:16:37]

The CQ bit was checked by rogerta@chromium.org

[Roger Tawa OOO till Jul 10th, 2015-03-17 12:16:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mlerman@chromium.org
Link to the patchset: https://codereview.chromium.org/956363002/#ps220001
(title: "rebased")

[commit-bot: I haz the power, 2015-03-17 12:16:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/956363002/220001

[commit-bot: I haz the power, 2015-03-17 13:09:01]

Committed patchset #10 (id:220001)

[commit-bot: I haz the power, 2015-03-17 13:15:55]

Patchset 10 (id:??) landed as
https://crrev.com/373bf95a0e730548db69a625cf147295b3d8fcd9
Cr-Commit-Position: refs/heads/master@{#320907}