LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html - Issue 956333002: Refactor TimeBase to post tasks. Workers to use real Idle tasks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html

Issue 956333002: Refactor TimeBase to post tasks. Workers to use real Idle tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html ('k') | LayoutTests/http/tests/security/suborigins/resources/childsuborigin.php » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html

diff --git a/LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html b/LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html

index c0d9682e675a13d10b43b2a5fb8d6a471da9a38c..8c34837c4bbbf7bdd3361e40177471364649af67 100644

--- a/LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html

+++ b/LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html

@@ -1,5 +1,12 @@

- window.location = "pass.html";

+ // We need to wait until the iframe has finished loading before navigating or

+ // we risk getting duplicate prints from WebTestProxyBase::DidFinishDocumentLoad

+ // due to a race between the FrameLoader::startLoad due to setting window.location

+ // and Document::finishedParsing both of which call FrameLoader::finishedParsing

+ // which in turn calls. WebTestProxyBase::DidFinishDocumentLoad.

+ window.onload = function() {

+ window.location = "pass.html";

+ }

window.onunload = function()

{