Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1471)

Unified Diff: Source/core/workers/WorkerThread.h

Issue 956333002: Refactor TimeBase to post tasks. Workers to use real Idle tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changed the idle implementation Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/workers/WorkerThread.h
diff --git a/Source/core/workers/WorkerThread.h b/Source/core/workers/WorkerThread.h
index 1ac816457ec1767d3193d861ff84a469016d24ca..6c0114ecc25be05f84e0a54248bffe30dfe96a05 100644
--- a/Source/core/workers/WorkerThread.h
+++ b/Source/core/workers/WorkerThread.h
@@ -47,7 +47,6 @@ class WebWaitableEvent;
class WorkerGlobalScope;
class WorkerInspectorController;
class WorkerReportingProxy;
-class WorkerSharedTimer;
class WorkerThreadShutdownFinishTask;
class WorkerThreadStartupData;
class WorkerThreadTask;
@@ -123,15 +122,19 @@ protected:
virtual void terminateV8Execution();
private:
- friend class WorkerSharedTimer;
+ friend class WorkerThreadIdleTask;
friend class WorkerThreadShutdownFinishTask;
+ friend class WorkerThreadWaitUntilIdleTask;
+ friend class WorkerThreadWakeupIdleTask;
void stopInShutdownSequence();
void stopInternal();
void initialize();
void cleanup();
- void idleHandler();
+ void dontStartIdleTaskYet();
Sami 2015/04/02 10:59:20 Should these be talking about the idle period inst
+ void maybeStartIdleTask();
+ void idleTask(double deadlineSeconds);
void postDelayedTask(PassOwnPtr<ExecutionContextTask>, long long delayMs);
void postDelayedTask(const WebTraceLocation&, PassOwnPtr<ExecutionContextTask>, long long delayMs);
@@ -158,6 +161,8 @@ private:
// Used to signal thread termination.
OwnPtr<WebWaitableEvent> m_terminationEvent;
+ bool m_dontStartIdleTaskYet;
+
// FIXME: This has to be last because of crbug.com/401397 - the
// WorkerThread might get deleted before it had a chance to properly
// shut down. By deleting the WebThread first, we can guarantee that

Powered by Google App Engine
This is Rietveld 408576698