LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html - Issue 956333002: Refactor TimeBase to post tasks. Workers to use real Idle tasks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html

Issue 956333002: Refactor TimeBase to post tasks. Workers to use real Idle tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <script>	1 <script>

2 window.location = "pass.html";	2 // We need to wait until the iframe has finished loading before navigating o r

	3 // we risk getting duplicate prints from WebTestProxyBase::DidFinishDocument Load

	4 // due to a race between the FrameLoader::startLoad due to setting window.lo cation

	5 // and Document::finishedParsing both of which call FrameLoader::finishedPar sing

	6 // which in turn calls. WebTestProxyBase::DidFinishDocumentLoad.

	7 window.onload = function() {
	rmcilroy 2015/04/17 12:59:32 Could we make the layouttest changes in a seperate Could we make the layouttest changes in a seperate CL (I assume they work both with and without these changes?). alex clarke (OOO till 29th) 2015/04/17 13:37:08 Possibly. I think that might depend on who does t Show quoted text On 2015/04/17 12:59:32, rmcilroy wrote: > Could we make the layouttest changes in a seperate CL (I assume they work both > with and without these changes?). Possibly. I think that might depend on who does the owners review. rmcilroy 2015/04/17 16:33:22 I'm not sure what you mean here. LayoutTest change Show quoted text On 2015/04/17 13:37:08, alexclarke1 wrote: > On 2015/04/17 12:59:32, rmcilroy wrote: > > Could we make the layouttest changes in a seperate CL (I assume they work both > > with and without these changes?). > > Possibly. I think that might depend on who does the owners review. I'm not sure what you mean here. LayoutTest changes don't need OWNER's reviews so you could land these changes independently of this change if it's possible (I think this would make it clearer that the change shouldn't change behaviour well written layouttests if it didn't modify any itself, but I don't really mind either way).
	8 window.location = "pass.html";

	9 }

3	10

4 window.onunload = function()	11 window.onunload = function()

5 {	12 {

6 document.write("document.write");	13 document.write("document.write");

7 setTimeout("parent.log('You wanted to go to: '+ location.href); parent.f ail()", 500);	14 setTimeout("parent.log('You wanted to go to: '+ location.href); parent.f ail()", 500);

8 }	15 }

9 </script>	16 </script>

OLD	NEW