Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: Source/core/html/track/TextTrackCue.h

Issue 956323002: Tweak the TextTrackCue "cue index" management (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 double startTime() const { return m_startTime; } 64 double startTime() const { return m_startTime; }
65 void setStartTime(double); 65 void setStartTime(double);
66 66
67 double endTime() const { return m_endTime; } 67 double endTime() const { return m_endTime; }
68 void setEndTime(double); 68 void setEndTime(double);
69 69
70 bool pauseOnExit() const { return m_pauseOnExit; } 70 bool pauseOnExit() const { return m_pauseOnExit; }
71 void setPauseOnExit(bool); 71 void setPauseOnExit(bool);
72 72
73 int cueIndex(); 73 unsigned cueIndex();
philipj_slow 2015/02/26 15:43:12 I'm not sure if Blink or Chromium has an exception
fs 2015/02/26 16:09:34 Blink most certainly is excepted (to not just say
74 void invalidateCueIndex(); 74 void updateCueIndex(unsigned cueIndex) { m_cueIndex = cueIndex; }
75 75
76 using EventTarget::dispatchEvent; 76 using EventTarget::dispatchEvent;
77 virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override; 77 virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
78 78
79 bool isActive(); 79 bool isActive();
80 void setIsActive(bool active) { m_isActive = active; } 80 void setIsActive(bool active) { m_isActive = active; }
81 81
82 virtual void updateDisplay(HTMLDivElement& container) = 0; 82 virtual void updateDisplay(HTMLDivElement& container) = 0;
83 83
84 // FIXME: Consider refactoring to eliminate or merge the following three mem bers. 84 // FIXME: Consider refactoring to eliminate or merge the following three mem bers.
(...skipping 20 matching lines...) Expand all
105 protected: 105 protected:
106 TextTrackCue(double start, double end); 106 TextTrackCue(double start, double end);
107 107
108 void cueWillChange(); 108 void cueWillChange();
109 virtual void cueDidChange(); 109 virtual void cueDidChange();
110 110
111 private: 111 private:
112 AtomicString m_id; 112 AtomicString m_id;
113 double m_startTime; 113 double m_startTime;
114 double m_endTime; 114 double m_endTime;
115 int m_cueIndex;
116 115
117 RawPtrWillBeMember<TextTrack> m_track; 116 RawPtrWillBeMember<TextTrack> m_track;
118 117
118 unsigned m_cueIndex;
119
119 bool m_isActive : 1; 120 bool m_isActive : 1;
120 bool m_pauseOnExit : 1; 121 bool m_pauseOnExit : 1;
121 }; 122 };
122 123
123 } // namespace blink 124 } // namespace blink
124 125
125 #endif // TextTrackCue_h 126 #endif // TextTrackCue_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698