Fix favicon padding in Site Settings on pre-L devices.

Fix favicon padding in Site Settings on pre-L devices.

The problem was that the preference layout is quite different between L
and pre-L devices, so adjusting the padding of the icon's parent view
had very different effects in those two cases. Now, we simply set the
padding of the icon view itself to get the favicon where we want it.

BUG=454850
Committed: https://crrev.com/aa788c1cf0f961541a7806460948eb01f3ea0147
Cr-Commit-Position: refs/heads/master@{#318749}

[newt (away), 2015-02-27 02:55:41]

newt@chromium.org changed reviewers:
+ finnur@chromium.org

[newt (away), 2015-02-27 02:55:42]

PTAL

screenshots on the bug:
https://code.google.com/p/chromium/issues/detail?id=454850#c7

[newt (away), 2015-02-27 02:58:00]

https://codereview.chromium.org/956303003/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java
(right):

https://codereview.chromium.org/956303003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java:64:
setIcon(new ColorDrawable(Color.TRANSPARENT));
With this change, it doesn't matter what the size of the drawable is, since icon
ImageViews in preferences always have a fixed size.

[Finnur, 2015-02-27 11:29:14]

I don't have any comments on the code, but the screenshots for L and pre-L vary
quite a lot in terms of padding for the icon. The L edition looks like it is
lacking left-padding whereas pre-L seems to have a bit too much.

Is that expected?

[newt (away), 2015-02-27 18:53:39]

On 2015/02/27 11:29:14, Finnur wrote:
> I don't have any comments on the code, but the screenshots for L and pre-L
vary
> quite a lot in terms of padding for the icon. The L edition looks like it is
> lacking left-padding whereas pre-L seems to have a bit too much.
> 
> Is that expected?

Yes. On L, the layout matches the spec (see link on the bug). On both L and
pre-L, the layout matches other preferences with icons (e.g. the main Site
Settings screen).

In general, Settings on pre-L doesn't quite match the spec -- the spacing is all
a little different -- bit it's internally consistent and it's consistent with
the platform and other apps.

[newt (away), 2015-02-27 19:21:47]

On 2015/02/27 18:53:39, newt wrote:
> On 2015/02/27 11:29:14, Finnur wrote:
> > I don't have any comments on the code, but the screenshots for L and pre-L
> vary
> > quite a lot in terms of padding for the icon. The L edition looks like it is
> > lacking left-padding whereas pre-L seems to have a bit too much.
> > 
> > Is that expected?
> 
> Yes. On L, the layout matches the spec (see link on the bug). On both L and
> pre-L, the layout matches other preferences with icons (e.g. the main Site
> Settings screen).
> 
> In general, Settings on pre-L doesn't quite match the spec -- the spacing is
all
> a little different -- bit it's internally consistent and it's consistent with
> the platform and other apps.

p.s. I uploaded a screenshot of Site Settings on L and pre-L for comparison:
https://code.google.com/p/chromium/issues/detail?id=454850#c8

[Finnur, 2015-03-02 09:08:00]

Hmm... ok. LGTM

[newt (away), 2015-03-02 19:07:14]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-03-02 19:08:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/956303003/20001

[commit-bot: I haz the power, 2015-03-02 19:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-02 19:12:38]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[newt (away), 2015-03-02 19:22:52]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-03-02 19:22:53]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/956303003/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-03-02 19:23:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/956303003/40001

[commit-bot: I haz the power, 2015-03-02 21:04:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-02 21:05:06]

Patchset 3 (id:??) landed as
https://crrev.com/aa788c1cf0f961541a7806460948eb01f3ea0147
Cr-Commit-Position: refs/heads/master@{#318749}