Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: src/lookup-inl.h

Issue 956283003: Don't perform access checks for internally used properties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup-inl.h
diff --git a/src/lookup-inl.h b/src/lookup-inl.h
index ffc02e78783adefdd8216ef09313403f857d6b8b..50f4b0fcc9ddad89849b64fa71183077f8f97480 100644
--- a/src/lookup-inl.h
+++ b/src/lookup-inl.h
@@ -38,7 +38,10 @@ LookupIterator::State LookupIterator::LookupInHolder(Map* map,
switch (state_) {
case NOT_FOUND:
if (map->IsJSProxyMap()) return JSPROXY;
- if (map->is_access_check_needed()) return ACCESS_CHECK;
+ if (map->is_access_check_needed() &&
+ !isolate_->IsInternallyUsedPropertyName(name_)) {
+ return ACCESS_CHECK;
+ }
// Fall through.
case ACCESS_CHECK:
if (check_interceptor() && map->has_named_interceptor()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698