components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc - Issue 956223002: Rename DataReductionProxyUsageStats to DataReductionProxyBypassStats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

Issue 956223002: Rename DataReductionProxyUsageStats to DataReductionProxyBypassStats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

index 773015c8ebf22883dc47cb1c0e513e30520aaf18..28de78c0a72f390875ea94ac75518b0c54416785 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

@@ -5,7 +5,7 @@

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.h"

-#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h"

+#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"

#include "net/http/http_response_headers.h"

#include "net/url_request/url_request.h"

@@ -18,9 +18,9 @@ namespace data_reduction_proxy {

DataReductionProxyInterceptor::DataReductionProxyInterceptor(

DataReductionProxyConfig* config,

- DataReductionProxyUsageStats* stats,

+ DataReductionProxyBypassStats* stats,

DataReductionProxyEventStore* event_store)

- : usage_stats_(stats),

+ : bypass_stats_(stats),

bypass_protocol_(

new DataReductionProxyBypassProtocol(config, event_store)) {

}

@@ -56,8 +56,8 @@ DataReductionProxyInterceptor::MaybeInterceptResponseOrRedirect(

DataReductionProxyBypassType bypass_type = BYPASS_EVENT_TYPE_MAX;

bool should_retry = bypass_protocol_->MaybeBypassProxyAndPrepareToRetry(

request, &bypass_type);

- if (usage_stats_ && bypass_type != BYPASS_EVENT_TYPE_MAX)

- usage_stats_->SetBypassType(bypass_type);

+ if (bypass_stats_ && bypass_type != BYPASS_EVENT_TYPE_MAX)

+ bypass_stats_->SetBypassType(bypass_type);

if (!should_retry)

return nullptr;

// Returning non-NULL has the effect of restarting the request with the