Chromium Code Reviews
Help | Chromium Project | Sign in

Issue 9562029: GTK: Draw the correct omnibox state with new tab-to-traverse behavior. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
3 years ago by Elliot Glaysher
3 years ago
Peter Kasting
chromium-reviews, James Su


GTK: Draw the correct omnibox state with new tab-to-traverse behavior. This does everything but animate the trailing ">" icon from the right side of the omnibox to the left when entering tab-to-search mode. The TTS arrow indicator is now properly GTK themed, as well. (Doing the animation is lower priority. It would require more extensive refactoring that I don't have time for as I have code yellow work.) BUG=116292 TEST=all new tab-to-search behavior matches views sans animation. Committed:

Patch Set 1 #

Total comments: 3

Patch Set 2 : pkasting nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -10 lines) Patch
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h View 1 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/ View 1 8 chunks +51 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/ View 3 chunks +5 lines, -1 line 0 comments Download


Total messages: 4 (0 generated)
Elliot Glaysher
3 years ago (2012-03-01 21:57:49 UTC) #1
Peter Kasting
LGTM. Refactoring would really take longer than a day? File chrome/browser/ui/gtk/omnibox/ (right): chrome/browser/ui/gtk/omnibox/ ...
3 years ago (2012-03-01 22:02:12 UTC) #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at
3 years ago (2012-03-01 22:23:54 UTC) #3
I haz the power (commit-bot)
3 years ago (2012-03-02 01:04:47 UTC) #4
Change committed as 124552
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87e6a26