Chromium Code Reviews
Help | Chromium Project | Sign in
(13)

Issue 9562029: GTK: Draw the correct omnibox state with new tab-to-traverse behavior. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by Elliot Glaysher
Modified:
3 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

GTK: Draw the correct omnibox state with new tab-to-traverse behavior. This does everything but animate the trailing ">" icon from the right side of the omnibox to the left when entering tab-to-search mode. The TTS arrow indicator is now properly GTK themed, as well. (Doing the animation is lower priority. It would require more extensive refactoring that I don't have time for as I have code yellow work.) BUG=116292 TEST=all new tab-to-search behavior matches views sans animation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124552

Patch Set 1 #

Total comments: 3

Patch Set 2 : pkasting nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -10 lines) Patch
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h View 1 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 8 chunks +51 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/theme_service_gtk.cc View 3 chunks +5 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
3 years, 5 months ago (2012-03-01 21:57:49 UTC) #1
Peter Kasting
LGTM. Refactoring would really take longer than a day? https://chromiumcodereview.appspot.com/9562029/diff/1/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc File chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc (right): https://chromiumcodereview.appspot.com/9562029/diff/1/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc#newcode491 chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc:491: ...
3 years, 5 months ago (2012-03-01 22:02:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9562029/5001
3 years, 5 months ago (2012-03-01 22:23:54 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2012-03-02 01:04:47 UTC) #4
Change committed as 124552
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5