Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 956193002: Clean up perftesthelper.js style (Closed)

Created:
5 years, 10 months ago by alancutter (OOO until 2018)
Modified:
5 years, 10 months ago
Reviewers:
qyearsley
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up perftesthelper.js style This change makes tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js consistent with the Chromium Javascript style guide: - Fixed indentation - Added missing semicolon - Renamed file to be underscore separated Committed: https://crrev.com/9f85387cb8ce5504e84f99c23b3bfb2cd9a3b33b Cr-Commit-Position: refs/heads/master@{#318358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -109 lines) Patch
M tools/perf/page_sets/tough_animation_cases/balls_css_keyframe_animations.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_css_keyframe_animations_composited_transform.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_css_transition_2_properties.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_css_transition_40_properties.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_css_transition_all_properties.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_javascript_canvas.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_javascript_css.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_svg_animations.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_many_keyframes.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_simultaneous_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_simultaneous_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_simultaneous_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_simultaneous_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_chaining_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_chaining_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_chaining_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_chaining_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_infinite_iterations.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_triggering_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_triggering_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_triggering_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_triggering_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_color.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_filter.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_length_3d.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_length_complex.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_length_simple.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_shadow.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_transform_complex.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_transform_simple.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/overlay_background_color_css_transitions.html View 1 chunk +1 line, -1 line 0 comments Download
A tools/perf/page_sets/tough_animation_cases/resources/perf_test_helper.js View 1 chunk +61 lines, -0 lines 0 comments Download
D tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js View 1 chunk +0 lines, -60 lines 0 comments Download
M tools/perf/page_sets/tough_animation_cases/web_animations_many_keyframes.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/web_animations_set_current_time_in_raf.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/web_animations_simultaneous.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/web_animations_staggered_chaining.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/web_animations_staggered_infinite_iterations.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/web_animations_staggered_triggering.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
alancutter (OOO until 2018)
Whoops, forgot to upload this again. This is a reupload of: https://codereview.chromium.org/927583005/ Missed renames fixed ...
5 years, 10 months ago (2015-02-26 05:05:10 UTC) #2
qyearsley
On 2015/02/26 05:05:10, alancutter wrote: > Whoops, forgot to upload this again. > > This ...
5 years, 10 months ago (2015-02-26 16:32:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956193002/1
5 years, 10 months ago (2015-02-26 22:14:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-27 00:41:13 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-27 00:41:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f85387cb8ce5504e84f99c23b3bfb2cd9a3b33b
Cr-Commit-Position: refs/heads/master@{#318358}

Powered by Google App Engine
This is Rietveld 408576698