Fix developer_private.js for closure compiler

third_party/closure_compiler/externs/developer_private.js

Index: third_party/closure_compiler/externs/developer_private.js
diff --git a/third_party/closure_compiler/externs/developer_private.js b/third_party/closure_compiler/externs/developer_private.js
index 34d2541d5ddd0f0060ef16ee9eeaca6a48f672a9..56b9149d4a303b11486cc765b2a5b0a9619098c9 100644
--- a/third_party/closure_compiler/externs/developer_private.js
+++ b/third_party/closure_compiler/externs/developer_private.js
@@ -4,7 +4,8 @@
 
 /** @fileoverview Externs generated from namespace: developerPrivate */
 
-// Note: hand-modified to change Array to !Array in ItemInfo typedef.
+// Note: hand-modified to change Array to !Array in ItemInfo typedef, and to
+// change enum types to strings.
 
 /**
  * @typedef {{
@@ -34,7 +35,7 @@ var InstallWarning;
  *   enabled: boolean,
  *   disabled_reason: (string|undefined),
  *   isApp: boolean,
- *   type: ItemType,

[Dan Beam, 2015/02/25 21:42:57]

can we just add a @typedef (or @enum if this is one) instead?

[Devlin, 2015/02/25 22:15:43]

Added @typedefs for them. We can't really use @enum, because we don't generate
enums for these values in the bindings (even though we should).  "enum" as used
in the json/idl files basically just means "we promise it's one of these", but
are always actually strings.

+ *   type: string,
  *   allow_activity: boolean,
  *   allow_file_access: boolean,
  *   wants_file_access: boolean,
@@ -74,7 +75,7 @@ var InspectOptions;
  *   item_path: string,
  *   pem_path: string,
  *   override_flags: number,
- *   status: PackStatus
+ *   status: string
  * }}
  */
 var PackDirectoryResponse;
@@ -88,7 +89,7 @@ var ProjectInfo;
 
 /**
  * @typedef {{
- *   event_type: EventType,
+ *   event_type: string,
  *   item_id: string
  * }}
  */
@@ -174,8 +175,8 @@ chrome.developerPrivate.loadDirectory = function(directory, callback) {};
 
 /**
  * Open Dialog to browse to an entry.
- * @param {SelectType} select_type Select a file or a folder.
- * @param {FileType} file_type Required file type. For Example pem type is for
+ * @param {string} select_type Select a file or a folder.
+ * @param {string} file_type Required file type. For Example pem type is for
  * private key and load type is for an unpacked item.
  * @param {Function} callback called with selected item's path.
  */
@@ -196,5 +197,19 @@ chrome.developerPrivate.packDirectory = function(path, private_key_path, flags,
  */
 chrome.developerPrivate.isProfileManaged = function(callback) {};
 
+/**
+ * Reads and returns the contents of a file related to an extension which
+ * caused an error.
+ * @param {?} dict
+ * @param {Function} callback
+ */
+chrome.developerPrivate.requestFileSource = function(dict, callback) {};

[Devlin, 2015/02/25 20:29:39]

I didn't think we needed these, because closure compiler is totally happy right
now (without any definition).  Any idea why?

+
+/**
+ * Open the developer tools to focus on a particular error.
+ * @param {?} dict
+ */
+chrome.developerPrivate.openDevTools = function(dict) {};
+
 /** @type {!ChromeEvent} */
 chrome.developerPrivate.onItemStateChanged;