Fix developer_private.js for closure compiler

third_party/closure_compiler/externs/developer_private.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Externs generated from namespace: developerPrivate */
 
-// Note: hand-modified to change Array to !Array in ItemInfo typedef.
+// Note: hand-modified to change Array to !Array in ItemInfo typedef, and to
+// change enum types to strings.
 
 /**
  * @typedef {{
  *   path: string,
  *   render_process_id: number,
  *   render_view_id: number,
  *   incognito: boolean,
  *   generatedBackgroundPage: boolean
  * }}
  */
 var ItemInspectView;
 
 /**
  * @typedef {{
  *   message: string
  * }}
  */
 var InstallWarning;
 
 /**
  * @typedef {{
  *   id: string,
  *   name: string,
  *   version: string,
  *   description: string,
  *   may_disable: boolean,
  *   enabled: boolean,
  *   disabled_reason: (string|undefined),
  *   isApp: boolean,
- *   type: ItemType,

[Dan Beam, 2015/02/25 21:42:57]

can we just add a @typedef (or @enum if this is one) instead?

[Devlin, 2015/02/25 22:15:43]

Added @typedefs for them. We can't really use @enum, because we don't generate
enums for these values in the bindings (even though we should).  "enum" as used
in the json/idl files basically just means "we promise it's one of these", but
are always actually strings.

+ *   type: string,
  *   allow_activity: boolean,
  *   allow_file_access: boolean,
  *   wants_file_access: boolean,
  *   incognito_enabled: boolean,
  *   is_unpacked: boolean,
  *   allow_reload: boolean,
  *   terminated: boolean,
  *   allow_incognito: boolean,
  *   icon_url: string,
  *   path: (string|undefined),
@@ skipping 19 matching lines @@
  * }}
  */
 var InspectOptions;
 
 /**
  * @typedef {{
  *   message: string,
  *   item_path: string,
  *   pem_path: string,
  *   override_flags: number,
- *   status: PackStatus
+ *   status: string
  * }}
  */
 var PackDirectoryResponse;
 
 /**
  * @typedef {{
  *   name: string
  * }}
  */
 var ProjectInfo;
 
 /**
  * @typedef {{
- *   event_type: EventType,
+ *   event_type: string,
  *   item_id: string
  * }}
  */
 var EventData;
 
 /**
  * @const
  */
 chrome.developerPrivate = {};
 
@@ skipping 65 matching lines @@
 
 /**
  * Loads an extension / app from a given |directory|
  * @param {Object} directory
  * @param {Function} callback
  */
 chrome.developerPrivate.loadDirectory = function(directory, callback) {};
 
 /**
  * Open Dialog to browse to an entry.
- * @param {SelectType} select_type Select a file or a folder.
- * @param {FileType} file_type Required file type. For Example pem type is for
+ * @param {string} select_type Select a file or a folder.
+ * @param {string} file_type Required file type. For Example pem type is for
  * private key and load type is for an unpacked item.
  * @param {Function} callback called with selected item's path.
  */
 chrome.developerPrivate.choosePath = function(select_type, file_type, callback) {};
 
 /**
  * Pack an item with given |path| and |private_key_path|
  * @param {string} path
  * @param {string} private_key_path
  * @param {number} flags
  * @param {Function} callback called with the success result string.
  */
 chrome.developerPrivate.packDirectory = function(path, private_key_path, flags, callback) {};
 
 /**
  * Returns true if the profile is managed.
  * @param {Function} callback
  */
 chrome.developerPrivate.isProfileManaged = function(callback) {};
 
+/**
+ * Reads and returns the contents of a file related to an extension which
+ * caused an error.
+ * @param {?} dict
+ * @param {Function} callback
+ */
+chrome.developerPrivate.requestFileSource = function(dict, callback) {};

[Devlin, 2015/02/25 20:29:39]

I didn't think we needed these, because closure compiler is totally happy right
now (without any definition).  Any idea why?

+
+/**
+ * Open the developer tools to focus on a particular error.
+ * @param {?} dict
+ */
+chrome.developerPrivate.openDevTools = function(dict) {};
+
 /** @type {!ChromeEvent} */
 chrome.developerPrivate.onItemStateChanged;