Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 956063002: Fix developer_private.js for closure compiler (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix developer_private.js for closure compiler Automated definition used enum types instead of strings, and it looks like we need to include the two functions which take "any" arguments. BUG=461039 Committed: https://crrev.com/ceb01b3f0b024d2fc4bc4e19fa79715c8d7c0a43 Cr-Commit-Position: refs/heads/master@{#318143}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M third_party/closure_compiler/externs/developer_private.js View 1 3 chunks +41 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Devlin
Hey Dan, sorry for the noise. https://codereview.chromium.org/956063002/diff/1/third_party/closure_compiler/externs/developer_private.js File third_party/closure_compiler/externs/developer_private.js (right): https://codereview.chromium.org/956063002/diff/1/third_party/closure_compiler/externs/developer_private.js#newcode206 third_party/closure_compiler/externs/developer_private.js:206: chrome.developerPrivate.requestFileSource = function(dict, ...
5 years, 10 months ago (2015-02-25 20:29:39 UTC) #2
Dan Beam
https://codereview.chromium.org/956063002/diff/1/third_party/closure_compiler/externs/developer_private.js File third_party/closure_compiler/externs/developer_private.js (left): https://codereview.chromium.org/956063002/diff/1/third_party/closure_compiler/externs/developer_private.js#oldcode37 third_party/closure_compiler/externs/developer_private.js:37: * type: ItemType, can we just add a @typedef ...
5 years, 10 months ago (2015-02-25 21:42:58 UTC) #3
Devlin
https://codereview.chromium.org/956063002/diff/1/third_party/closure_compiler/externs/developer_private.js File third_party/closure_compiler/externs/developer_private.js (left): https://codereview.chromium.org/956063002/diff/1/third_party/closure_compiler/externs/developer_private.js#oldcode37 third_party/closure_compiler/externs/developer_private.js:37: * type: ItemType, On 2015/02/25 21:42:57, Dan Beam wrote: ...
5 years, 10 months ago (2015-02-25 22:15:43 UTC) #4
Dan Beam
lgtm (also we should update that script to this when possible)
5 years, 10 months ago (2015-02-25 22:25:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956063002/20001
5 years, 10 months ago (2015-02-25 22:29:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 23:29:00 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 23:30:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ceb01b3f0b024d2fc4bc4e19fa79715c8d7c0a43
Cr-Commit-Position: refs/heads/master@{#318143}

Powered by Google App Engine
This is Rietveld 408576698