Use blink::initDataType and blink::sessionType as enums

Use blink::initDataType and blink::sessionType as enums

BUG=418239
TEST=EME tests still pass

Committed: https://crrev.com/c9d8e531d5a079836e789a0192b3fd6d3cf056f8
Cr-Commit-Position: refs/heads/master@{#318269}

[jrummell, 2015-02-25 22:11:50]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org

[jrummell, 2015-02-25 22:11:50]

PTAL. To land after https://codereview.chromium.org/950813005/.

[sandersd (OOO until July 31), 2015-02-25 22:41:47]

lgtm

https://codereview.chromium.org/955993004/diff/1/media/blink/webcontentdecryp...
File media/blink/webcontentdecryptionmodulesession_impl.cc (right):

https://codereview.chromium.org/955993004/diff/1/media/blink/webcontentdecryp...
media/blink/webcontentdecryptionmodulesession_impl.cc:98: std::string
init_data_type_as_ascii;
Should probably set this to "unknown" (in case no switch case matches).

https://codereview.chromium.org/955993004/diff/1/media/blink/webcontentdecryp...
media/blink/webcontentdecryptionmodulesession_impl.cc:101:
init_data_type_as_ascii = "cenc";
Since these constants are spreading, perhaps create a bug an reference it here?

https://codereview.chromium.org/955993004/diff/1/media/blink/webcontentdecryp...
media/blink/webcontentdecryptionmodulesession_impl.cc:131:
MediaKeys::SessionType session_type_enum;
Set to TEMPORARY.

[jrummell, 2015-02-25 23:34:32]

Updated.

https://codereview.chromium.org/955993004/diff/1/media/blink/webcontentdecryp...
File media/blink/webcontentdecryptionmodulesession_impl.cc (right):

https://codereview.chromium.org/955993004/diff/1/media/blink/webcontentdecryp...
media/blink/webcontentdecryptionmodulesession_impl.cc:98: std::string
init_data_type_as_ascii;
On 2015/02/25 22:41:46, sandersd wrote:
> Should probably set this to "unknown" (in case no switch case matches).

Done.

https://codereview.chromium.org/955993004/diff/1/media/blink/webcontentdecryp...
media/blink/webcontentdecryptionmodulesession_impl.cc:101:
init_data_type_as_ascii = "cenc";
On 2015/02/25 22:41:46, sandersd wrote:
> Since these constants are spreading, perhaps create a bug an reference it
here?

Done.

https://codereview.chromium.org/955993004/diff/1/media/blink/webcontentdecryp...
media/blink/webcontentdecryptionmodulesession_impl.cc:131:
MediaKeys::SessionType session_type_enum;
On 2015/02/25 22:41:46, sandersd wrote:
> Set to TEMPORARY.

Done.

[jrummell, 2015-02-26 17:51:44]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2015-02-26 17:51:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/955993004/#ps20001 (title:
"default")

[commit-bot: I haz the power, 2015-02-26 17:52:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/955993004/20001

[commit-bot: I haz the power, 2015-02-26 18:38:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-26 18:39:13]

Patchset 2 (id:??) landed as
https://crrev.com/c9d8e531d5a079836e789a0192b3fd6d3cf056f8
Cr-Commit-Position: refs/heads/master@{#318269}