Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 955963002: Add version macros. (Closed)

Created:
5 years, 10 months ago by bnoordhuis
Modified:
5 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add version macros. Add public version macros. I can't test the release script for obvious reasons but tools/test-push-to-trunk.sh seems happy. Side note: tools/v8-info.sh seems to have been broken ever since the move to git. At least it's not more broken now. BUG=v8:3075 LOG=y

Patch Set 1 #

Total comments: 1

Patch Set 2 : Implement TypedArray.slice(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -13 lines) Patch
M src/typedarray.js View 1 2 chunks +35 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/typedarrays.js View 1 2 chunks +62 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bnoordhuis
5 years, 10 months ago (2015-02-25 12:05:59 UTC) #2
Michael Achenbach
Generally lg. I'll hijack this CL and land it in sync with a cherry-pick of ...
5 years, 10 months ago (2015-02-25 14:57:13 UTC) #4
Michael Starzinger
Handing off into Michael A.'s capable hands and removing myself as reviewer. Thanks!
5 years, 10 months ago (2015-02-25 15:03:20 UTC) #6
Michael Achenbach
5 years, 10 months ago (2015-02-26 09:00:22 UTC) #7
This landed here now https://codereview.chromium.org/959713003/

Thanks for your work! I'll close this CL.

Powered by Google App Engine
This is Rietveld 408576698