Issue 955933002: Files.app: Stop reusing items' DOM in grid view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 955933002: Files.app: Stop reusing items' DOM in grid view. (Closed)

Created:
5 years, 10 months ago by hirono

Modified:
5 years, 10 months ago

Reviewers:
fukino

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: Stop reusing items' DOM in grid view. Previously the image DOM in the list is removed for reusing for another item unintentionally. Thanks to ListThumbnailLoader we no longer need to reuse DOM. BUG=461338 TEST=None Committed: https://crrev.com/3d8d4115aa6c0f1a34081e1553a724c5f4247c6c Cr-Commit-Position: refs/heads/master@{#318003}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -56 lines)			Patch
	M	ui/file_manager/file_manager/foreground/js/ui/file_grid.js	View		11 chunks	+16 lines, -56 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955933002/1

5 years, 10 months ago (2015-02-25 08:31:14 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 09:41:13 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3d8d4115aa6c0f1a34081e1553a724c5f4247c6c
Cr-Commit-Position: refs/heads/master@{#318003}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages