Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: Source/core/animation/StringKeyframe.cpp

Issue 955863002: Support keywords in LengthStyleInterpolation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: transitions test with interpolated perspective Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/StringKeyframe.cpp
diff --git a/Source/core/animation/StringKeyframe.cpp b/Source/core/animation/StringKeyframe.cpp
index 113b9819d0506588f1e332c38a5d31576013572e..6dc34a7800c566ff1d417b2ecac74990ae38c648 100644
--- a/Source/core/animation/StringKeyframe.cpp
+++ b/Source/core/animation/StringKeyframe.cpp
@@ -194,12 +194,9 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
case CSSPropertyVerticalAlign:
case CSSPropertyWordSpacing:
case CSSPropertyWebkitColumnRuleWidth:
- if (LengthStyleInterpolation::canCreateFrom(*fromCSSValue) && LengthStyleInterpolation::canCreateFrom(*toCSSValue))
+ if (LengthStyleInterpolation::canCreateFrom(*fromCSSValue, property) && LengthStyleInterpolation::canCreateFrom(*toCSSValue, property))
return LengthStyleInterpolation::create(*fromCSSValue, *toCSSValue, property, range);
- // FIXME: Handle keywords e.g. 'none'.
- if (property == CSSPropertyPerspective)
- fallBackToLegacy = true;
// FIXME: Handle keywords e.g. 'smaller', 'larger'.
if (property == CSSPropertyFontSize)
fallBackToLegacy = true;
@@ -208,13 +205,6 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
if (property == CSSPropertyBaselineShift)
fallBackToLegacy = true;
- // FIXME: Handle keywords e.g. 'normal'
- if (property == CSSPropertyLetterSpacing)
- fallBackToLegacy = true;
-
- // FIXME: Handle keywords e.g. 'thick'
- if (property == CSSPropertyOutlineWidth || property == CSSPropertyWebkitColumnRuleWidth)
- fallBackToLegacy = true;
break;
case CSSPropertyOrphans:
case CSSPropertyWidows:
« no previous file with comments | « Source/core/animation/LengthStyleInterpolation.cpp ('k') | Source/core/animation/css/CSSAnimatableValueFactory.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698