Source/core/animation/LengthStyleInterpolation.h - Issue 955863002: Support keywords in LengthStyleInterpolation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/LengthStyleInterpolation.h

Issue 955863002: Support keywords in LengthStyleInterpolation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/animations/interpolation/perspective-interpolation-expected.txt ('k') | Source/core/animation/LengthStyleInterpolation.cpp » ('j') | Source/core/animation/LengthStyleInterpolation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/LengthStyleInterpolation.h

diff --git a/Source/core/animation/LengthStyleInterpolation.h b/Source/core/animation/LengthStyleInterpolation.h

index 35401806cf657de17e86260261382a417064a3dd..b25c32840086a559aa449808370e69ea24ec55c7 100644

--- a/Source/core/animation/LengthStyleInterpolation.h

+++ b/Source/core/animation/LengthStyleInterpolation.h

@@ -18,16 +18,16 @@ public:

static PassRefPtrWillBeRawPtr<LengthStyleInterpolation> create(const CSSValue& start, const CSSValue& end, CSSPropertyID id, InterpolationRange range)

{

- return adoptRefWillBeNoop(new LengthStyleInterpolation(toInterpolableValue(start), toInterpolableValue(end), id, range));

+ return adoptRefWillBeNoop(new LengthStyleInterpolation(toInterpolableValue(start, id), toInterpolableValue(end, id), id, range));

}

- static bool canCreateFrom(const CSSValue&);

+ static bool canCreateFrom(const CSSValue&, CSSPropertyID = CSSPropertyInvalid);

virtual void apply(StyleResolverState&) const override;

virtual void trace(Visitor*) override;

- static PassOwnPtrWillBeRawPtr<InterpolableValue> toInterpolableValue(const CSSValue&);

+ static PassOwnPtrWillBeRawPtr<InterpolableValue> toInterpolableValue(const CSSValue&, CSSPropertyID = CSSPropertyInvalid);

static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> fromInterpolableValue(const InterpolableValue&, InterpolationRange);

private: