Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 955813002: Make ChannelMojoHost::ChannelDelegate a RefContedThreadSafe (Closed)

Created:
5 years, 10 months ago by Hajime Morrita
Modified:
5 years, 9 months ago
Reviewers:
agl, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ChannelMojoHost::ChannelDelegate a RefContedThreadSafe ChannelDelegate::GetWeakPtr() was called from the UI thread but it was racy as the weak ptr is also used in the IO thread. This CL turns ChannelDelegate a ThreadSafeRefCounted so that we can pass ChannelDelegate itself to the task runner, instead of using its weak ptr on the UI thread. This change also turns some TaskRunner declarations to SequencedTaskRunner to access its DeleteSoon() API from ChannelDelegate. TBR=creis@chromium.org R=viettrungluu@chrormium.org, agl@chromium.org BUG=460243 Committed: https://crrev.com/70b91498930876d016b9716f2cc267373287976d Cr-Commit-Position: refs/heads/master@{#318994}

Patch Set 1 #

Patch Set 2 : Updated to ToT #

Patch Set 3 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo_host.h View 3 chunks +6 lines, -11 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_host.cc View 6 chunks +26 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Hajime Morrita
5 years, 10 months ago (2015-02-24 22:49:48 UTC) #1
agl
RS LGTM for ipc/
5 years, 10 months ago (2015-02-25 00:24:24 UTC) #2
Hajime Morrita
Trung: Ping?
5 years, 10 months ago (2015-02-25 19:07:55 UTC) #3
Hajime Morrita
OK, it's all green now. Trung, could you take a look? This is a TSAN ...
5 years, 9 months ago (2015-03-02 21:26:36 UTC) #4
Hajime Morrita
Trung: Ping?
5 years, 9 months ago (2015-03-03 20:18:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955813002/20001
5 years, 9 months ago (2015-03-03 23:10:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/65135)
5 years, 9 months ago (2015-03-03 23:44:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955813002/40001
5 years, 9 months ago (2015-03-04 00:05:37 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-04 01:52:46 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 01:53:40 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/70b91498930876d016b9716f2cc267373287976d
Cr-Commit-Position: refs/heads/master@{#318994}

Powered by Google App Engine
This is Rietveld 408576698