Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 955723002: Revert of Revert of Turn on job based recompilation (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Turn on job based recompilation (patchset #1 id:1 of https://codereview.chromium.org/937263004/) Reason for revert: reland Original issue's description: > Revert of Turn on job based recompilation (patchset #1 id:1 of https://codereview.chromium.org/935243003/) > > Reason for revert: > waterfall disagrees > > Original issue's description: > > Turn on job based recompilation > > > > BUG=v8:3608 > > R=yangguo@chromium.org > > LOG=y > > > > Committed: https://crrev.com/4ae82f64b09cdc0182cee3a5cc619a9117ac5fbc > > Cr-Commit-Position: refs/heads/master@{#26826} > > TBR=yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3608 > > Committed: https://crrev.com/35cc692aecdea54fb07479b8d7b71059851e07e8 > Cr-Commit-Position: refs/heads/master@{#26827} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3608 Committed: https://crrev.com/3735a0851a9e2726f8b50a46a3bc770992328264 Cr-Commit-Position: refs/heads/master@{#26829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Revert of Turn on job based recompilation
5 years, 10 months ago (2015-02-24 16:36:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955723002/1
5 years, 10 months ago (2015-02-24 16:37:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 16:37:25 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3735a0851a9e2726f8b50a46a3bc770992328264 Cr-Commit-Position: refs/heads/master@{#26829}
5 years, 10 months ago (2015-02-24 16:37:43 UTC) #4
rmcilroy
5 years, 9 months ago (2015-03-06 18:23:19 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/984463003/ by rmcilroy@chromium.org.

The reason for reverting is: Breaks Octane on Arm64 running on Chrome.

BUG=464538.

Powered by Google App Engine
This is Rietveld 408576698