Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 955713004: Merge 317853 - Make BackgroundContentsService start up BackgroundContents with a delay, as for Exte… (Closed)

Created:
5 years, 10 months ago by Yoyo Zhou
Modified:
5 years, 10 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Merge 317853 - Make BackgroundContentsService start up BackgroundContents with a delay, as for ExtensionHosts. extensions::ProcessManager starts ExtensionHosts asynchronously with a queue to avoid using too much resources at startup; make BackgroundContentsService use the same queue implementation. (ExtensionHostQueue now accepts an interface that both BackgroundContentsService and ExtensionHost share.) This significantly reduces the time BackgroundContentsService contributes to ExtensionService startup (75th percentile was ~300ms, according to Extensions.BackgroundContentsServiceStartupTime). BUG=47236 Review URL: https://codereview.chromium.org/933423003 Cr-Commit-Position: refs/heads/master@{#317480} (cherry picked from commit d61dfe19ab3188101e511f633eeaaef3dc689e41) Committed: https://chromium.googlesource.com/chromium/src/+/4bda951ed28b1e47ae0de179bbc03aad62b92b99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -46 lines) Patch
M chrome/browser/background/background_contents.h View 4 chunks +20 lines, -1 line 0 comments Download
M chrome/browser/background/background_contents.cc View 4 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_host_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_host_delegate.cc View 3 chunks +9 lines, -0 lines 0 comments Download
A extensions/browser/deferred_start_render_host.h View 1 chunk +27 lines, -0 lines 0 comments Download
M extensions/browser/extension_host.h View 7 chunks +9 lines, -8 lines 0 comments Download
M extensions/browser/extension_host.cc View 5 chunks +2 lines, -15 lines 0 comments Download
M extensions/browser/extension_host_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M extensions/browser/extension_host_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/serial_extension_host_queue.h View 2 chunks +11 lines, -10 lines 0 comments Download
M extensions/browser/serial_extension_host_queue.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/extensions.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/shell_extension_host_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/shell_extension_host_delegate.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Yoyo Zhou
5 years, 10 months ago (2015-02-24 21:42:43 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4bda951ed28b1e47ae0de179bbc03aad62b92b99.

Powered by Google App Engine
This is Rietveld 408576698