presubmit_canned_checks.py - Issue 955713003: Let clients pass the verbose level they want to cpplint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 955713003: Let clients pass the verbose level they want to cpplint. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 1e2d1ab62e39e4dba0dfe3b7ff935b4f6790ed6b..087188df5ec3545a840648850d041d57c96c50fb 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -112,7 +112,7 @@ def CheckDoNotSubmitInFiles(input_api, output_api):

def CheckChangeLintsClean(input_api, output_api, source_file_filter=None,

- lint_filters=None):

+ lint_filters=None, verbose_level=None):

"""Checks that all '.cc' and '.h' files pass cpplint.py."""

_RE_IS_TEST = input_api.re.compile(r'.*tests?.(cc|h)$')

result = []

@@ -136,7 +136,8 @@ def CheckChangeLintsClean(input_api, output_api, source_file_filter=None,

else:

level = 4

- cpplint.ProcessFile(file_name, level)

+ verbose_level = verbose_level or level

+ cpplint.ProcessFile(file_name, verbose_level)

if cpplint._cpplint_state.error_count > 0:

if input_api.is_committing:

« no previous file with comments | « no previous file | no next file » | no next file with comments »