Let clients pass the verbose level they want to cpplint.

Let clients pass the verbose level they want to cpplint.

This came in this CL review https://codereview.chromium.org/947983003/

BUG=None
R=dpranke@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294207

[tfarina, 2015-02-24 17:41:34]

Dirk, Dana, please, take a look.

[danakj, 2015-02-24 17:42:39]

Cool with me.

[Dirk Pranke, 2015-02-24 17:48:36]

lgtm

[tfarina, 2015-02-24 20:25:37]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-24 20:27:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/955713003/1

[commit-bot: I haz the power, 2015-02-24 20:30:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 20:30:33]

Presubmit check for 955713003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/push-basic.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1520 --:--:-- --:--:-- --:--:--  1540
TESTING: Base URL contains branch name
TESTING: git-cl land ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:10000/5629499534213120
Closing issue (you may be prompted for your codereview password)...
Traceback (most recent call last):
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 3081, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 3067, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2451, in CMDland
    return SendUpstream(parser, args, 'land')
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2319, in SendUpstream
    cl.RpcServer().add_comment(cl.GetIssue(), comment)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/rietveld.py",
line 262, in add_comment
    ('no_redirect', 'True')])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/rietveld.py",
line 396, in post
    return self._send(request_path, payload=body, content_type=ctype, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/rietveld.py",
line 421, in _send
    result = self.rpc_server.Send(request_path, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/third_party/upload.py",
line 460, in Send
    f = self.opener.open(req, timeout=70)
  File "/usr/lib/python2.7/urllib2.py", line 410, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 523, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 448, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 531, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 403: Forbidden
Sending crash report ...
  args: ['/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py',
'land', '-f']
  cwd: /b/infra_internal/commit_queue/workdir/tools/depot
  exception: HTTP Error 403: Forbidden
Headers: content-type: t
  host: cq.golo.chromium.org
  stack:   File "/b/infra_internal/commit_queue/workdir/too
  user: chrome-bot
  version: 2.7.6 (default, Mar 22 2014, 22:59:56) 
[GCC 4.8.2
A stack trace has been sent to the maintainers.
FAILURE: git-cl land ok


Presubmit checks took 192.9s to calculate.

[tfarina, 2015-02-24 20:32:21]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-24 20:32:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/955713003/1

[commit-bot: I haz the power, 2015-02-24 20:35:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 20:35:29]

Presubmit check for 955713003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/checkout_test.py (38.70s) failed
Cloning into '/tmp/trial7pCx6O/__main__.GitCheckout.testAll/foo'...
done.
Switched to branch 'master'
Already on 'master'
.ECloning into '/tmp/trial7pCx6O/__main__.GitCheckout.testMove/foo'...
done.
.Cloning into '/tmp/trial7pCx6O/__main__.GitCheckout.testProcess/foo'...
done.
....................
======================================================================
ERROR: testException (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 359, in set_up_git
    self.set_up()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 211, in set_up
    self.cleanup_dirt()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 229, in cleanup_dirt
    if not self.tear_down_git():
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 276, in tear_down_git
    wait_for_port_to_free(self.host, self.git_port)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 161, in wait_for_port_to_free
    assert False, '%d is still bound' % port
AssertionError: 20001 is still bound

----------------------------------------------------------------------
Ran 23 tests in 38.324s

FAILED (errors=1)


Presubmit checks took 171.8s to calculate.

[tfarina, 2015-02-24 21:59:32]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-24 22:00:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/955713003/1

[commit-bot: I haz the power, 2015-02-24 22:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 22:03:45]

Presubmit check for 955713003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (53.42s) failed
Ffatal: reference is not a tree: 6bff50cedb393001f7474ed48eab1093759c6bab
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
6bff50cedb393001f7474ed48eab1093759c6bab returned non-zero exit status 128 in
/tmp/trialPZGJ3Y/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialPZGJ3Y/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialPZGJ3Y/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 53.292s

FAILED (failures=1, errors=2)


Presubmit checks took 170.4s to calculate.

[tfarina, 2015-02-25 03:19:00]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-25 03:19:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/955713003/1

[commit-bot: I haz the power, 2015-02-25 03:23:13]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294207