Issue 955713002: Some clean-up now that ChromeTab's native counterpart is removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 955713002: Some clean-up now that ChromeTab's native counterpart is removed. (Closed)

Created:
5 years, 10 months ago by Yaron

Modified:
5 years, 10 months ago

Reviewers:
Ted C

CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Some clean-up now that ChromeTab's native counterpart is removed. TabAndroid is not intended to be subclassed so remove virtuals. Also restrict access to native pointer from java. BUG=443773 Committed: https://crrev.com/bdc6b5dc1609b685e98d0ee92b040a6f41879cfc Cr-Commit-Position: refs/heads/master@{#318044}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -22 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/Tab.java	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/android/tab_android.h	View		2 chunks	+19 lines, -21 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955713002/1

5 years, 10 months ago (2015-02-25 14:47:15 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 14:51:05 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bdc6b5dc1609b685e98d0ee92b040a6f41879cfc
Cr-Commit-Position: refs/heads/master@{#318044}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages