Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 955653005: Add ViewConfiguration and make our scrollbar size match Android (Closed)

Created:
5 years, 10 months ago by eseidel
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add ViewConfiguration and make our scrollbar size match Android Turns out scrollbars are very inconsistent throughout Android apps. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b3565a725163ac4d02fd9149ce2c978ddb48ae65

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M sky/framework/sky-scrollable.sky View 1 3 chunks +25 lines, -2 lines 0 comments Download
A sky/framework/view-configuration.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
5 years, 10 months ago (2015-02-24 21:44:32 UTC) #1
abarth-chromium
https://codereview.chromium.org/955653005/diff/1/sky/framework/sky-scrollable.sky File sky/framework/sky-scrollable.sky (right): https://codereview.chromium.org/955653005/diff/1/sky/framework/sky-scrollable.sky#newcode82 sky/framework/sky-scrollable.sky:82: //_vbar.style['border-radius'] = "${paintWidth / 2}px"; Remove commented out code? ...
5 years, 10 months ago (2015-02-24 21:48:25 UTC) #2
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-24 22:16:15 UTC) #3
eseidel
5 years, 10 months ago (2015-02-24 22:23:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b3565a725163ac4d02fd9149ce2c978ddb48ae65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698