Adding Maps page to page_sets for telemetry.

tools/telemetry/telemetry/page/actions/drag.js

Index: tools/telemetry/telemetry/page/actions/drag.js
diff --git a/tools/telemetry/telemetry/page/actions/drag.js b/tools/telemetry/telemetry/page/actions/drag.js
new file mode 100644
index 0000000000000000000000000000000000000000..8787d18223e1e6f21c95cf524b9065663f1f7603
--- /dev/null
+++ b/tools/telemetry/telemetry/page/actions/drag.js
@@ -0,0 +1,70 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file provides the DragAction object, which performs drag on a page
+// using given start and end positions:
+//   1. var action = new __DragAction(callback)
+//   2. action.start(drag_options)
+'use strict';
+
+(function() {
+  function DragGestureOptions(opt_options) {
+      this.element_ = opt_options.element;
+      this.left_start_ratio_ = opt_options.left_start_ratio;
+      this.top_start_ratio_ = opt_options.top_start_ratio;
+      this.left_end_ratio_ = opt_options.left_end_ratio;
+      this.top_end_ratio_ = opt_options.top_end_ratio;
+      this.speed_ = opt_options.speed;
+      this.gesture_source_type_ = opt_options.gesture_source_type;
+  }
+
+  function supportedByBrowser() {
+    return !!(window.chrome &&
+              chrome.gpuBenchmarking &&
+              chrome.gpuBenchmarking.smoothDrag);
+  }
+
+  // This class performs drag action using given start and end positions,
+  // by a single drag gesture.
+  function DragAction(opt_callback) {
+    this.beginMeasuringHook = function() {}
+    this.endMeasuringHook = function() {}
+
+    this.callback_ = opt_callback;
+  }
+
+  DragAction.prototype.start = function(opt_options) {
+    this.options_ = new DragGestureOptions(opt_options);
+    requestAnimationFrame(this.startGesture_.bind(this));
+  };
+
+  DragAction.prototype.startGesture_ = function() {
+    this.beginMeasuringHook();
+
+    var rect = __GestureCommon_GetBoundingVisibleRect(this.options_.element_);
+    var start_left =
+        rect.left + rect.width * this.options_.left_start_ratio_;

[picksi, 2015/03/02 14:11:05]

nit: calculate...

var pixel_width = rect.width * this.options_.left_start_ratio_

and 'pixel_height' (might want to choose a better name!) instead of
re-calculating each value twice.

[ssid, 2015/03/02 20:09:41]

As we discussed, added brackets and these are different variables, and not
re-calculated.

[picksi, 2015/03/03 13:36:06]

OK. This looks clear with brackets! Thanks.

+    var start_top =
+        rect.top + rect.height * this.options_.top_start_ratio_;
+    var end_left =
+        rect.left + rect.width * this.options_.left_end_ratio_;
+    var end_top =

[picksi, 2015/03/02 14:11:05]

nit: Are start_top/end_top, start_left/end_left the correct names for these? Are
they really tops & lefts or should they be start_X/end_X and start_Y/end_Y?

Ideally we'd keep these in a vector (if such a thing exists in this bit of the
code), and then we could use start.x, start.y, end.x, end.y ... but I may be
misunderstanding what these values are used for.

[ssid, 2015/03/02 20:09:41]

It is named top and left because the html style properties are named top and
left. There is no vector operation being done here. The function of this file is
to call the extension API(in c++) using these values, by getting the values from
python module to run benchmark. I don't see clearly how to make all of these as
vectors, since we can only pass int between them. What do you think?

[picksi, 2015/03/03 13:36:06]

If these top/left naming reflects their usage this is fine. Also fine if these
aren't actually vectors!

+        rect.top + rect.height * this.options_.top_end_ratio_;
+    chrome.gpuBenchmarking.smoothDrag(
+        start_left, start_top, end_left, end_top,
+        this.onGestureComplete_.bind(this), this.options_.gesture_source_type_,
+        this.options_.speed_);
+  };
+
+  DragAction.prototype.onGestureComplete_ = function() {
+    this.endMeasuringHook();
+
+    // We're done.
+    if (this.callback_)
+      this.callback_();
+  };
+
+  window.__DragAction = DragAction;
+  window.__DragAction_SupportedByBrowser = supportedByBrowser;
+})();