Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: tools/perf/page_sets/top_pages.py

Issue 955653003: Adding Maps page to page_sets for telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mousedrag2
Patch Set: Disabled for android. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/top_pages.py
diff --git a/tools/perf/page_sets/top_pages.py b/tools/perf/page_sets/top_pages.py
index 582cf986c3730dc44f3ddabebf83542cf59e1f6e..f85d00282b5fe2438a4e17c589a98cb78e6c0dc9 100644
--- a/tools/perf/page_sets/top_pages.py
+++ b/tools/perf/page_sets/top_pages.py
@@ -98,6 +98,23 @@ class GoogleDocPage(TopPages):
action_runner.WaitForJavaScriptCondition(
'document.getElementsByClassName("kix-appview-editor").length')
+# Disabled on android since the desktop record of maps don't load in android.
Sami 2015/02/27 15:33:06 nit: s/don't/doesn't/
ssid 2015/03/02 12:03:27 Done.
+class GoogleMapsPage(TopPages):
+
+ """ Why: productivity, top google properties; drag and drop anywhere """
Sami 2015/02/27 15:33:06 Same question about the last part of this.
ssid 2015/03/02 12:03:28 Done.
+
+ def __init__(self, page_set):
+ super(GoogleMapsPage, self).__init__(
+ url='https://www.google.co.uk/maps/@51.5043968,-0.1526806',
+ page_set=page_set,
+ name='Maps')
+
+ def CanRunOnBrowser(self, browser_info):
+ if (browser_info._browser._platform_backend.platform.GetOSName() ==
Sami 2015/02/27 15:33:06 nit: this could be shortened to return ... GetOSNa
ssid 2015/03/02 12:03:28 Done.
+ 'android'):
+ return False
+ return True;
+
class GooglePlusPage(TopPages):

Powered by Google App Engine
This is Rietveld 408576698