Adding Maps page to page_sets for telemetry.

tools/telemetry/telemetry/page/actions/drag_unittest.py

+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+import os
+
+from telemetry.page.actions import drag
+from telemetry.unittest_util import tab_test_case
+

[Sami, 2015/03/02 14:03:56]

nit: two blank lines between top-level entries.

[ssid, 2015/03/02 20:09:41]

Done.

+class DragActionTest(tab_test_case.TabTestCase):
+  def testDragAction(self):

[Sami, 2015/03/02 14:03:56]

Does this test also work on Android with the mouse events?

[ssid, 2015/03/02 20:09:41]

Added touch events to work on android.

+    self.Navigate('draggable.html')
+
+    with open(os.path.join(os.path.dirname(__file__),
+                           'gesture_common.js')) as f:
+      js = f.read()
+      self._tab.ExecuteJavaScript(js)
+
+    div_width = self._tab.EvaluateJavaScript(
+        '__GestureCommon_GetBoundingVisibleRect(document.body).width')
+    div_height = self._tab.EvaluateJavaScript(
+        '__GestureCommon_GetBoundingVisibleRect(document.body).height')
+
+    i = drag.DragAction(left_start_ratio=0.5, top_start_ratio=0.5,
+            left_end_ratio=0.25, top_end_ratio=0.25)
+    i.WillRunAction(self._tab)
+    self._tab.ExecuteJavaScript("""
+        window.__dragAction.beginMeasuringHook = function() {

[picksi, 2015/03/02 14:11:05]

You use single quotes around embedded code in drag.py, should probably be
consistent. I believe single quotes are preferred.

[ssid, 2015/03/02 20:09:42]

Is this your suggestion?

        'window.__dragAction.beginMeasuringHook = function() {' +
        '    window.__didBeginMeasuring = true;' +
        '};' +
        'window.__dragAction.endMeasuringHook = function() {' +
        '    window.__didEndMeasuring = true;' +
        '};'
Isnt it easier to understand the code with the former?

[picksi, 2015/03/03 13:36:06]

I'm suggesting you either stick with """ or ''', currently you use both ("""
here and ''' at line 81 in drag.py)

[ssid, 2015/03/03 14:50:08]

Yes! now I I get it. Thanks.

+            window.__didBeginMeasuring = true;
+        };
+        window.__dragAction.endMeasuringHook = function() {
+            window.__didEndMeasuring = true;
+        };""")
+    i.RunAction(self._tab)
+
+    self.assertTrue(self._tab.EvaluateJavaScript('window.__didBeginMeasuring'))
+    self.assertTrue(self._tab.EvaluateJavaScript('window.__didEndMeasuring'))
+
+    div_position_x = self._tab.EvaluateJavaScript(
+        'document.getElementById("drag_div").offsetLeft')
+    div_position_y = self._tab.EvaluateJavaScript(
+        'document.getElementById("drag_div").offsetTop')
+
+    # 0.25 is the ratio of displacement to the initial size.

[picksi, 2015/03/02 14:11:05]

nit: Change 0.25 in the comment to '4' or (probably better) change /4 to *0.25
in the code.

[ssid, 2015/03/02 20:09:42]

Changed.

+    self.assertTrue(div_position_x == div_width / 4,

[Sami, 2015/03/02 14:03:56]

This looks like it might fail if anything adds rounding errors to the
coordinates. We should probably make this a little less strict and only make
sure we are within one CSS pixel of the result (i.e., cast to an int). Also,
could we use assertEquals?

[ssid, 2015/03/02 20:09:42]

It converts the result to int because both the operands are ints. But I had to
take floor value. Is this correct now?

+                    msg="Moved element's left coordinate: %d, expected: %d" %
+                    (div_position_x, div_width / 4))
+    self.assertTrue(div_position_y == div_height / 4,
+                    msg="Moved element's top coordinate: %d, expected: %d" %
+                    (div_position_y, div_height / 4))