pkg/compiler/lib/src/js_backend/constant_emitter.dart - Issue 955613002: Revert "dart2js: Avoid escaping in strings if it's not necessary."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/constant_emitter.dart

Issue 955613002: Revert "dart2js: Avoid escaping in strings if it's not necessary." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/js_backend/constant_emitter.dart

diff --git a/pkg/compiler/lib/src/js_backend/constant_emitter.dart b/pkg/compiler/lib/src/js_backend/constant_emitter.dart

index d0b286c758e4d978115dd2aebef6a1f089706de1..234e2a01615904554a52c282c033e7ad507e039e 100644

--- a/pkg/compiler/lib/src/js_backend/constant_emitter.dart

+++ b/pkg/compiler/lib/src/js_backend/constant_emitter.dart

@@ -287,7 +287,9 @@ class ConstantLiteralEmitter

@override

jsAst.Expression visitString(StringConstantValue constant, [_]) {

- return js.escapedString(constant.primitiveValue.slowToString());

+ StringBuffer sb = new StringBuffer();

+ writeJsonEscapedCharsOn(constant.primitiveValue.slowToString(), sb);

+ return new jsAst.LiteralString('"$sb"');

}

@override

« no previous file with comments | « pkg/compiler/lib/src/js/builder.dart ('k') | tests/compiler/dart2js/string_escapes2_test.dart » ('j') | no next file with comments »